Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarifiying who votes. #544

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: clarifiying who votes. #544

merged 1 commit into from
Dec 11, 2023

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Nov 28, 2023

The link between sections 4 and 6 could be still clearer and definitively establish that votes for new CCs must come from current CCs.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 28, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @e0d! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@e0d
Copy link
Contributor Author

e0d commented Nov 28, 2023

@ehuthmacher FYI, does this clarify?

@ehuthmacher
Copy link

@e0d I don't seem to see the updated text. Where is it?

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting for eng review PR is ready for review. Review and merge it, or suggest changes. waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Nov 29, 2023
@ehuthmacher
Copy link

@e0d Yes, looks good to me. Thank you!

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 7, 2023
@itsjeyd
Copy link

itsjeyd commented Dec 7, 2023

@e0d @ehuthmacher It looks like this is ready for merge? :)

@ehuthmacher
Copy link

@itsjeyd Yes, it's ready for merge. Thank you!

@feanil feanil merged commit 439737e into master Dec 11, 2023
2 checks passed
@feanil feanil deleted the e0d/clarify-voting branch December 11, 2023 17:44
@openedx-webhooks
Copy link

@e0d 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@feanil feanil mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e0d @openedx-webhooks @ehuthmacher @itsjeyd @feanil